I have a number of Nitecore products, they've lasted for years and I have never had an issue with any of them.
The other issue with modern lights are all the light level options. I have an LED Lenser ST300 press for on at brightest, press again for the lower level - that's it. Mechanical not electronic switch - it has lasted for years ad shows not sign of failing. I rather like Olights, but the Oclip Pro has a whole raft of options that it doesn't need - I can see what they were doing when they developed a 'one size fits all' design and I am very pleased with mine, but with that additional complexity comes an increased risk of failure. I like a 'press the switch for on and press again for off' set up.
You give options for single mode operation.
Not for everyone, some folks believe CR123 to be exotic and/or obsolete. In 1990 a dive shop owner told me CR123 wouldn't be around in 10 years. That memory always reminds me that opinions aren't always fact
Also, the future is a notoriously difficult thing to accurately predict. I wouldn’t go so far as to say they are obsolete. But I would say the heyday of CR123 is in the past. There was a time when the finest flashlights in the world ran on CR123s. But today, with the exception of a few somewhat niche applications (long term term storage, possibly cold weather), CR123s just don’t stack up well against modern rechargeable Li-ion batteries in terms of performance.Some of the modern dual fuel lights (e.g. 1x18650 or 2xCR123) are interesting though.
Looking at traditional Maglites and similar, they are so dead simple (and designed to be user-serviceable) that there is very little that can go wrong that can’t be easily fixed. There are no complicated electronics. Batteries and bulbs are user-replaceable, so other than battery leakage/corrosion or switch failure they should last a very, very long time.
I appreciate your opinion too